fix: resolve the CAdeploy pipeline issue #586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abdul-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft and
aniaroramsft
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR renames a deployment parameter in the CAdeploy GitHub workflow to improve clarity and consistency.
- Changed the parameter name from
AzureOpenAILocationtoaiDeploymentsLocationin the Azure CLI deployment command.
Comments suppressed due to low confidence (2)
.github/workflows/CAdeploy.yml:122
- Verify that the
infra/main.biceptemplate has been updated to acceptaiDeploymentsLocationinstead ofAzureOpenAILocation; a mismatch will cause deployment failures.
--parameters aiDeploymentsLocation=${{ env.AZURE_LOCATION }} environmentName=${{ env.SOLUTION_PREFIX }} cosmosLocation=eastus2 gptDeploymentCapacity=${{ env.GPT_MIN_CAPACITY }} embeddingDeploymentCapacity=${{ env.TEXT_EMBEDDING_MIN_CAPACITY }} \
.github/workflows/CAdeploy.yml:122
- [nitpick] For consistency with other singular parameters like
cosmosLocation, consider renamingaiDeploymentsLocationtoaiDeploymentLocation.
--parameters aiDeploymentsLocation=${{ env.AZURE_LOCATION }} environmentName=${{ env.SOLUTION_PREFIX }} cosmosLocation=eastus2 gptDeploymentCapacity=${{ env.GPT_MIN_CAPACITY }} embeddingDeploymentCapacity=${{ env.TEXT_EMBEDDING_MIN_CAPACITY }} \
Roopan-Microsoft
approved these changes
Jul 2, 2025
Roopan-Microsoft
approved these changes
Jul 2, 2025
|
🎉 This PR is included in version 1.5.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
.github/workflows/CAdeploy.ymlfile, focusing on renaming a parameter to improve clarity and consistency.Workflow improvement:
AzureOpenAILocationtoaiDeploymentsLocationin the Azure deployment command to align with naming conventions and improve readability. ([.github/workflows/CAdeploy.ymlL122-R122](https://github.com/microsoft/Build-your-own-copilot-Solution-Accelerator/pull/586/files#diff-67593888fa4a3b8c26f65fe9387615f60cda88c80b3eb1407e6330d5e8bb1468L122-R122))Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information